On Thu, Jul 3, 2008 at 8:07 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > >> - netif_carrier_on(dev); >> ifsta->flags |= IEEE80211_STA_PREV_BSSID_SET; >> memcpy(ifsta->prev_bssid, sdata->u.sta.bssid, ETH_ALEN); >> memcpy(wrqu.ap_addr.sa_data, sdata->u.sta.bssid, ETH_ALEN); >> ieee80211_sta_send_associnfo(dev, ifsta); >> } else { >> + netif_carrier_off(dev); >> ieee80211_sta_tear_down_BA_sessions(dev, ifsta->bssid); >> ifsta->flags &= ~IEEE80211_STA_ASSOCIATED; >> - netif_carrier_off(dev); > > Maybe it should then be symmetric so that callers of the function have > to do it in both cases? Other than that, looks good. The sequence now is configure association in the driver -> carrier_on ..... carrier_off -> configure disassociation in the driver So this is already symmetric or I don't understand what you mean. Thanks Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html