On 04/18/2018 02:26 PM, Johannes Berg wrote:
On Tue, 2018-04-17 at 18:49 -0700, greearb@xxxxxxxxxxxxxxx wrote:
+ * @get_ethtool_stats2: Return extended statistics about the device.
+ * This is only useful if the device maintains statistics not
+ * included in &struct rtnl_link_stats64.
+ * Takes a flags argument: 0 means all (same as get_ethtool_stats),
+ * 0x1 (ETHTOOL_GS2_SKIP_FW) means skip firmware stats.
+ * Other flags are reserved for now.
It'd be pretty hard to know which flags are firmware stats?
Yes, it is, but ethtool stats are difficult to understand in a generic
manner anyway, so someone using them is already likely aware of low-level
details of the driver(s) they are using.
In my case, I have lots of virtual stations (or APs), and I want stats
for them as well as for the 'radio', so I would probe the first vdev with
flags of 'skip-none' to get all stats, including radio (firmware) stats.
And then the rest I would just probe the non-firmware stats.
To be honest, I was slightly amused that anyone expressed interest in
this patch originally, but maybe other people have similar use case
and/or drivers with slow-to-acquire stats.
Anyway, there's no way I'm going to take this patch, so you need to
float it on netdev first (best CC us here) and get it applied there
before we can do anything on the wifi side.
I posted the patches to netdev, ath10k and linux-wireless. If I had only
posted them individually to different lists I figure I'd be hearing about how
the netdev patch is useless because it has no driver support, etc.
Thanks,
Ben
--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc http://www.candelatech.com
