Rob Herring <robh@xxxxxxxxxx> writes: > On Tue, Apr 10, 2018 at 10:19:46PM +0530, Govind Singh wrote: >> Add device tree binding documentation details for wcn3990 >> wifi block present in Qualcomm SDM845/APQ8098 SoC into >> "qcom,ath10k.txt". >> >> Signed-off-by: Govind Singh <govinds@xxxxxxxxxxxxxx> >> --- >> .../bindings/net/wireless/qcom,ath10k.txt | 31 ++++++++++++++++++++++ >> 1 file changed, 31 insertions(+) > > One nit, otherwise: > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > [...] >> @@ -119,3 +126,27 @@ wifi0: wifi@a000000 { >> qcom,msi_base = <0x40>; >> qcom,ath10k-pre-calibration-data = [ 01 02 03 ... ]; >> }; >> + >> +Example (to supply wcn3990 SoC wifi block details): >> + >> +qcom,wifi@18000000 { > > wifi@... I added this and Rob's Reviewed-by to the patch in the pending branch: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=20f4accbe76af8f137b4218ce4973bda6fc3d23e Govind, please check that it's ok. -- Kalle Valo