Wen Gong <wgong@xxxxxxxxxxxxxx> wrote: > When trying to set wow wakeup patterns it fails with this command: > > iw phyxx wowlan enable patterns offset xx+ IP address xx.xx.xx.xx > > The reason is that the wow pattern from upper layer is in 802.3 format > for this case, it need to convert it to 802.11 format. The input > offset parameter is used for 802.3, but the actual offset firmware > need depends on rx_decap_mode, so that it needs to be recalculated. > Pattern of 802.3 packet is not same with 802.11 packet. If the > rx_decap_mode is ATH10K_HW_TXRX_NATIVE_WIFI, then firmware will > receive data packet with 802.11 format from hardware. > > Tested with QCA6174 hw3.0 with firmware > WLAN.RM.4.4.1-00099-QCARMSWPZ-1, but this will also affect QCA9377. > This has always failed, so it's not a regression with new firmware > releases. > > Signed-off-by: Wen Gong <wgong@xxxxxxxxxxxxxx> > Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx> This added a new checkpatch warning: drivers/net/wireless/ath/ath10k/wow.c:228: Missing a blank line after declarations I fixed it in the pending branch. -- https://patchwork.kernel.org/patch/10337877/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches