On Tue, 2018-04-10 at 02:19 +0000, Xinming Hu wrote: > Hi Kalle, > > > -----Original Message----- > > From: Kalle Valo [mailto:kvalo@xxxxxxxxxxxxxx] > > Sent: 2018年4月9日 18:51 > > To: Xinming Hu <huxm@xxxxxxxxxxx> > > Cc: Linux Wireless <linux-wireless@xxxxxxxxxxxxxxx>; Brian Norris > > <briannorris@xxxxxxxxxxxx>; Dmitry Torokhov <dtor@xxxxxxxxxx>; > > rajatja@xxxxxxxxxx; Zhiyuan Yang <yangzy@xxxxxxxxxxx>; Tim Song > > <songtao@xxxxxxxxxxx>; Cathy Luo <cluo@xxxxxxxxxxx>; James Cao > > <jcao@xxxxxxxxxxx>; Ganapathi Bhat <gbhat@xxxxxxxxxxx>; Ellie > > Reeves > > <ellierevves@xxxxxxxxx> > > Subject: Re: [v2 PATCH] mwifiex: parse key management suite from > > RSN IE > > > > Xinming Hu <huxm@xxxxxxxxxxx> writes: > > > > > Association failed when using wpa_supplicant with configuration > > > key_mgmt=WPA-PSK-SHA256, and it is noticed that wpa_supplicant > > > set > > > WLAN_AKM_SUITE_PSK_SHA256 in RSN IE, but miss it in start_ap > > > parameters. > > > > > > This patch parse key management suite from RSN IE, in case it is > > > missed. > > > > > > Signed-off-by: Xinming Hu <huxm@xxxxxxxxxxx> > > > > Shouldn't you fix wpa_supplicant instead of adding a workaround to > > the driver? > > > > Yes, I am preparing a wpa_supplicant fix on this. > Even so, driver fix is still need to compatible with old > wpa_supplicant stable release Typically the kernel does not add hacks to work around userspace software bugs. The userspace software needs to be fixed and upgraded. Dan