Hi On 2018-04-06, Kalle Valo wrote: > From: Sebastian Gottschall <s.gottschall@xxxxxxxxxxxxxxx> > > Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 based > chipsets with on chipset connected led's using WMI Firmware API. The LED > device will get available named as "ath10k-phyX" at sysfs and can be controlled > with various triggers. adds also debugfs interface for gpio control. > > Signed-off-by: Sebastian Gottschall <s.gottschall@xxxxxxxxxx> > Reviewed-by: Steve deRosier <derosier@xxxxxxxxxxxxxx> > [kvalo: major reorg and cleanup] > Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx> Tested-by: Stefan Lippers-Hollmann <s.l-h@xxxxxx> [...] I've been able to test v13 of this patch, including the changes regarding removing ath10k_leds_start() and moving the ath10k_wmi_gpio_config() call into ath10k_leds_set_brightness_blocking() as raised by Sebastian Gottschall, on a ZyXEL NBG6817 (using two QCA9984 wlan cards and firmware 10.4-3.5.3-00053) running OpenWrt/ master r6644-eda27d7557 (ipq8065, kernel 4.9.92 with backports wt-2017-11-01-0-gfe248fc2c180/ v4.14-rc2-1-31-g86cf0e5d). /sys/class/leds/ath10k-phy0/ and /sys/class/leds/ath10k-phy1/ are registered correctly and the white wlan LEDs connected to the ath10k GPIOs are now working as designed (controlled via phy0tpt/ phy1tpt). Thanks a lot to everyone involved! Regards Stefan Lippers-Hollmann
