On Thu, Apr 05, 2018 at 02:39:31PM +0300, Dan Carpenter wrote: > On Thu, Apr 05, 2018 at 01:30:35PM +0200, Johannes Berg wrote: > > On Thu, 2018-04-05 at 14:23 +0300, Dan Carpenter wrote: > > > The problem here is that we allocate "data". Then we do > > > "data = PTR_ALIGN(data, 8);" and then we free the aligned pointer and > > > not the one we allocated. > > > > That seems pretty pointless, since kmalloc guarantees such alignment for > > sure. Better to just remove PTR_ALIGN()? > > Yeah. You're probably right. I was thinking that maybe > ARCH_SLAB_MINALIGN was smaller than 8 somewhere but look it it now, I > think it's always 8 or more. > Perhaps on certain xtensa variants? arch/xtensa/include/asm/processor.h:#define ARCH_SLAB_MINALIGN XCHAL_DATA_WIDTH arch/xtensa/variants/fsf/include/variant/core.h:#define XCHAL_DATA_WIDTH 4 /* data width in bytes */ regards, dan carpenter
