Em Thu, 29 Mar 2018 16:26:33 +0200 Johannes Berg <johannes@xxxxxxxxxxxxxxxx> escreveu: > Hi, > > > The original patchset for nested structs was supporting it only > > when not inlined. This should be fixed on this patchset: > > > > https://lkml.org/lkml/2018/2/19/387 > > > > Do you have those patches on your tree? > > No, looks like I don't have those yet. I'll wait for those then. > > > With regards to duplicated warnings, that use to happen if the same header > > is included several times (with is a common pratice at the net subsystem). > > Yeah, doesn't really matter anyway. I think I have to, in a sense, > because I'm getting lots of functions separately from the headers. > > > Could you please merge from docs-next and see if those problems > > get solved? > > No, that doesn't seem to address it fully: > > net/mac80211/sta_info.h:586: warning: Function parameter or member 'tx_stats.packets' not described in 'sta_info' > net/mac80211/sta_info.h:586: warning: Function parameter or member 'tx_stats.bytes' not described in 'sta_info' > net/mac80211/sta_info.h:586: warning: Function parameter or member 'tx_stats.last_rate' not described in 'sta_info' > net/mac80211/sta_info.h:586: warning: Function parameter or member 'msdu' not described in 'sta_info' > > You can reproduce this in > > git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master > > (merging with docs-next) and running > > make SPHINXDIRS=driver-api/80211 htmldocs No need to run it for checking the errors... you can run just: ./scripts/kernel-doc -none net/mac80211/sta_info.h Applying the enclosed patch seems to work: <patch> diff --git a/net/mac80211/sta_info.h b/net/mac80211/sta_info.h index f64eb86ca64b..d81cb6155e8d 100644 --- a/net/mac80211/sta_info.h +++ b/net/mac80211/sta_info.h @@ -477,6 +477,10 @@ struct ieee80211_sta_rx_stats { * @tdls_chandef: a TDLS peer can have a wider chandef that is compatible to * the BSS one. * @tx_stats: TX statistics + * @tx_stats.packets: foo + * @tx_stats.last_rate: bar + * @tx_stats.bytes: foobar + * @tx_stats.msdu: foo * @rx_stats: RX statistics * @pcpu_rx_stats: per-CPU RX statistics, assigned only if the driver needs * this (by advertising the USES_RSS hw flag) </patch> What's weird is that tx_stats.msdu field seems to be parsed wrong. I'll take a look on it. Thanks, Mauro
