On Mon, Mar 26, 2018 at 05:15:55PM +0530, Ajay Singh wrote: > Cleanup patch to remove the unused global variables defined for p2p. > > Signed-off-by: Ajay Singh <ajay.kathat@xxxxxxxxxxxxx> > Reviewed-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx> > --- > drivers/staging/wilc1000/host_interface.c | 59 ------------------------------- > 1 file changed, 59 deletions(-) > > diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c > index 5082ede..a13998d 100644 > --- a/drivers/staging/wilc1000/host_interface.c > +++ b/drivers/staging/wilc1000/host_interface.c > @@ -254,13 +254,6 @@ static u32 inactive_time; > static u8 del_beacon; > static u32 clients_count; > > -static u8 *join_req; > -static u8 *info_element; > -static u8 mode_11i; > -static u8 auth_type; > -static u32 join_req_size; > -static u32 info_element_size; > -static struct wilc_vif *join_req_vif; These are not "globals", just static to this file. But yeah, global to the file, but when I think of "global", I think of "global to the whole kernel". Anyway, not a problem... greg k-h
