> -----Original Message----- > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > Sent: Wednesday, March 21, 2018 15:00 <snip> > > +int dma_configure(struct device *dev) > > +{ > > + if (dev->bus->dma_configure) > > + return dev->bus->dma_configure(dev); > > + > > + return 0; > > +} > > void dma_deconfigure(struct device *dev) > > Empty line after this new function? Sorry, couldn't help it :) > > > { > > of_dma_deconfigure(dev); > > diff --git a/drivers/base/platform.c b/drivers/base/platform.c > > index f1bf7b3..d2d5891 100644 > > --- a/drivers/base/platform.c > > +++ b/drivers/base/platform.c > > @@ -1130,6 +1130,11 @@ int platform_pm_restore(struct device *dev) > > > > #endif /* CONFIG_HIBERNATE_CALLBACKS */ > > <snip> > > + > > const struct dev_pm_ops *pm; > > > > const struct iommu_ops *iommu_ops; > > diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h > > index eb9eab4..c15986b 100644 > > --- a/include/linux/dma-mapping.h > > +++ b/include/linux/dma-mapping.h > > @@ -761,6 +761,7 @@ void *dma_mark_declared_memory_occupied(struct > device *dev, > > } > > #endif /* CONFIG_HAVE_GENERIC_DMA_COHERENT */ > > > > +int dma_common_configure(struct device *dev); > > #ifdef CONFIG_HAS_DMA > > Blank line after the new function declaration? > > Other than those very minor things, nice job, this looks good: > > Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> Thank you for the review :). I will fix your comments in next version. Regards, Nipun
