Search Linux Wireless

Re: [PATCH 04/11] staging: wilc1000: refactor WILC_WFI_p2p_rx() to avoid line over 80 char

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Also good for me, only one minor thing mentioned below.

On 20.03.2018 18:55, Ajay Singh wrote:
> +	if (subtype == GO_NEG_REQ || subtype == GO_NEG_RSP ||
> +	    subtype == P2P_INV_REQ || subtype == P2P_INV_RSP) {
> +		for (i = P2P_PUB_ACTION_SUBTYPE + 2; i < size; i++) {
> +			if (buff[i] == P2PELEM_ATTR_ID &&
> +			    !(memcmp(p2p_oui, &buff[i + 2], 4))) {
You can remove  "(" ")" around memcmp. Your choice.

> +				wilc_wfi_cfg_parse_rx_action(&buff[i + 6],
> +							     size - (i + 6));
> +				break;
> +			}
> +		}
> +	}



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux