Search Linux Wireless

Re: [PATCH 4/5] iwlwifi: mvm: fix array out of bounds reference

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Kalle,

On Fri, 2018-03-16 at 14:38 +0200, Kalle Valo wrote:
> Luca Coelho <luca@xxxxxxxxx> writes:
> 
> > From: Avraham Stern <avraham.stern@xxxxxxxxx>
> > 
> > When starting aggregation, the code checks the status of the queue
> > allocated to the aggregation tid, which might not yet be allocated
> > and thus the queue index may be invalid.
> > Fix this by reserving a new queue in case the queue id is invalid.
> > 
> > While at it, clean up some unreachable code (a condition that is
> > already handled earlier) and remove all the non-DQA comments since
> > non-DQA mode is no longer supported.
> 
> Doing cleanup on a patch for 4.16 is not really a good idea, I guess
> it's ok this time. But please do try to avoid that.

Yeah, I noticed this cleanup in the fix patch, but since it just
removed dead code, I didn't think it would be an issue.

--
Cheers,
Luca.



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux