On Tue, Mar 13, 2018 at 8:55 PM, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote: > Amitkumar Karwar <amitkarwar@xxxxxxxxx> writes: > >> From: Prameela Rani Garnepudi <prameela.j04cs@xxxxxxxxx> >> >> For few regulatory customizations, we are taking rsi_reg >> as module parameter. > > Why? We have a custom power table and country to region mapping, This setting will be used only for a special mode called 'dlcar' We want to have an option to enable this mode through a module parameter. This patch introduces a module parameter. Next patch makes use of it. Let me know if you have any suggestions here. >> +static u16 rsi_reg = RSI_REG_DEF; >> +module_param(rsi_reg, ushort, 0444) >> +MODULE_PARM_DESC(rsi_reg, "0 - RSI_REG_DEF, 1 - RSI_REG_DLCAR"); > > The documentation tells nothing. > Below are the details. I will add include this info if the approach and patches(6/10 and 7/10) look ok to you. 0 - RSI_REG_DEF Keep default regulatory configuration 1 - RSI_REG_DLCAR Enable custom settings for 'dlcar' mode Regards, Amitkumar