Search Linux Wireless

Re: Variable-length arrays considered bad

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Amitkumar Karwar <amitkarwar@xxxxxxxxx> writes:

> On Thu, Mar 8, 2018 at 2:10 PM, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote:
>> Hi,
>>
>> in an lkml discussion[1] it was mentioned that variable-length arrays
>> should not be used. Few warnings were found[2] from wireless:
>>
>> drivers/net/wireless/ath/ath9k/dfs.c:104:2: warning: ISO C90 forbids
>> variable length array 'max_bin' [-Wvla]
>> drivers/net/wireless/rsi/rsi_91x_sdio.c:570:2: warning: ISO C90
>> forbids variable length array 'temp_buf' [-Wvla]
>>
>> Patches welcome.
>>
>> [1]
>> https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@xxxxxxxxxxxxxx
>>
>> [2] http://paste.ubuntu.com/p/srQxwPQS9s/
>>
>
> I will submit a cleanup patch for RSI warning

Thanks, but Tobin was faster:

https://lkml.kernel.org/r/1520577493-24603-1-git-send-email-me@xxxxxxxx

He just forgot to CC linux-wireless.

-- 
Kalle Valo



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux