Matt Redfearn <matt.redfearn@xxxxxxxx> writes: > Attempting to build bcma.ko with BCMA_DRIVER_PCI_HOSTMODE=y results in > a build error due to use of symbols not exported from vmlinux: > > ERROR: "pcibios_enable_device" [drivers/bcma/bcma.ko] undefined! > ERROR: "register_pci_controller" [drivers/bcma/bcma.ko] undefined! > make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1 > > To prevent this, don't allow the host mode feature to be built if > CONFIG_BCMA=m > > Signed-off-by: Matt Redfearn <matt.redfearn@xxxxxxxx> > > --- > > Changes in v2: > Rebase on v4.16-rc1 > > drivers/bcma/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig > index ba8acca036df..cb0f1aad20b7 100644 > --- a/drivers/bcma/Kconfig > +++ b/drivers/bcma/Kconfig > @@ -55,7 +55,7 @@ config BCMA_DRIVER_PCI > > config BCMA_DRIVER_PCI_HOSTMODE > bool "Driver for PCI core working in hostmode" > - depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY > + depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY && BCMA = y Due to the recent regression in bcma I would prefer extra careful review before I apply this. So does this look ok to everyone? -- Kalle Valo
