Lorenzo Bianconi <lorenzo.bianconi@xxxxxxxxxx> writes: >> Lorenzo Bianconi <lorenzo.bianconi@xxxxxxxxxx> writes: >> >>>> On Thu, 15 Feb 2018 23:59:24 +0100, Lorenzo Bianconi wrote: >>>>> Introduce __mt7601u_rr and __mt7601u_vendor_single_wr routines in order >>>>> to make mt7601u_rmw and mt7601u_rmc atomic since it is possible that >>>>> read and write accesses of mt7601u_rmw/mt7601u_rmc can be interleaved >>>>> with a different write operation on the same register. >>>>> Moreover move write trace point in __mt7601u_vendor_single_wr >>>>> >>>>> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@xxxxxxxxxx> >>>> >>>> Could you provide an example of which accesses make it problematic? >>>> Is this fixing an actual bug? >>> >>> it is not an issue I had experimented, I noticed a theoretical race >>> reviewing the code. >> >> The commit log should always answer the question "Why?". If you find a >> theoretical issue in the code document that clearly in the commit log. >> That helps to choose correct tree and sending to stable releases etc. >> >> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_log_does_not_answer_why > > I have already sent a v2: https://patchwork.kernel.org/patch/10225849/ > Is the commit message ok? Yeah, I already applied it. -- Kalle Valo
