Sergey Matyukevich <sergey.matyukevich.os@xxxxxxxxxxxxx> writes: >> Sergey Matyukevich <sergey.matyukevich.os@xxxxxxxxxxxxx> writes: >> >> > From: Sergei Maksimenko <smaksimenko@xxxxxxxxxxxxx> >> > >> > Enable support of networked standby mode (NSM) on qsr10g devices. >> > Networked standby is a power saving mode when the device keeps >> > all existing network connections and returns to full power mode >> > on a network activity. When enabled, device enters standby mode >> > after 15 min of inactivity (no associated stations or no trattic). >> > This period can be changed by setting sysfs attribute standby_timeout >> > (0 disables NSM support). A module parameter auto_standby >> > (defaults to 1) controls enabling NSM support on module loading. >> > >> > Signed-off-by: Sergei Maksimenko <smaksimenko@xxxxxxxxxxxxx> >> >> Adding a new sysfs file for a wireless driver is usually a bad idea, I >> don't even remember when we had a case where it was ok to do that. In >> principle we want everything to go through cfg80211 using nl80211. >> >> Also I'm not really fond of the module parameter just to disable a >> feature. And there isn't even any justification why it's needed. > > Ok, noted. Then we will take a break and look for better ways to integrate > this feature. Meanwhile, if you have no concerns regarding the first three > patches in the series, is it possible to apply them ? Or I better send v3 ? Yeah, patches 1-3 are on my queue and I should apply them soon. -- Kalle Valo
