Hi Dan, On Tue, 27 Feb 2018 12:41:40 +0300 Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > The first 5 patches are good, but the last 3 are not OK. Thanks for your review comments. I will resubmit the patch series by only including first 5 patches. I will recheck the last 3 patches and submit them separately. > > Normally "tmp" is used as an iterator pointer or something along those > lines. For example, here is a good use of "tmp". > > tmp = left; > left = right; > right = tmp; > > In this example, you want to store a pointer temporarily, so what else > are you going to call it besides "tmp"? The name "tmp" doesn't mean > "I want a short name and I'm too lazy to think of one". > Sure, I will take care of this point in subsequent patches. Regards, Ajay
