Hello Jeremy, Hello Hans, On Tue, Feb 20, 2018 at 5:15 PM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > Hi, > > On 02/20/2018 03:36 PM, Carlo Caione wrote: >> >> On Tue, Feb 20, 2018 at 2:01 PM, Hans de Goede <hdegoede@xxxxxxxxxx> >> wrote: >>> >>> Hi Carlo, >> >> >> Hi Hans, >> >>> Is this for devices with a RTL8723BS chip? If so then they >>> still will not work after this since there also no longer is >>> a /dev/ttyS4 created for the UART for the bluetooth, instead >>> you probably want: >>> >>> >>> https://github.com/jwrdegoede/linux-sunxi/commit/c383dac5ea00738ac01d704d820aa548494fcd41 >>> >>> Which also puts the /dev/ttyS4 back in place. >> >> >> Yeah, this problem came up while working on the RTL8723BS chip but the >> driver is also broken for the other two GPS devices supported by this >> driver. >> Thank you for the patch BTW. >> >>> Regards, >>> >>> Hans >>> >>> p.s. >>> >>> My college Jeremy Cline in the Cc is looking into getting proper >>> bluetooth support in place for the rtl8723bs using serdev binding >>> and having everything in the kernel, as we now already do for bcm >>> uart bluetooth modules. >> >> >> Wasn't also Martin (+CC) working on this? See >> https://www.spinics.net/lists/linux-bluetooth/msg73594.html thank you for CC'ing me Carlo! > Ah I did not know that, cool. Jeremy, this is probably a good starting > point :) And you should probably coordinate with Martin on this. the status on this is: - Marcel wrote a tool to parse the config blob: [0] - the first patch from my series called "serdev: implement parity configuration" is now obsolete because an improved version from Ulrich Hecht has been merged: [1] (this requires a trivial change to the "serdev_device_set_parity" call in patch #9 of my series) - I still have Realtek serdev support on my TODO-list but with low priority there was a discussion what has to be done to drop the "RFC" prefix from my series: [3] the quick summary (from my point of view): - if possible we should get rid of the config blob (don't use it at all or generate it in-memory - I couldn't make either of these work so far but I've not spent much time on it either) - create a "library" for the H5 protocol (similar to the H4 protocol) so the Realtek code doesn't have to be part of hci_h5.c - add ACPI support (and not just device-tree support) - testing with existing Realtek USB devices is needed I have successfully tested v2 of my series on two Amlogic boards I have which both come with a RTL8723BS SDIO wifi/UART Bluetooth combo chip. that said, I only looked at Bluetooth support (I didn't test wifi or btcoex support) and I don't have any "Realtek USB Bluetooth" dongles to check that I didn't break support for the existing devices @Jeremy: I definitely won't be able to update my patches for the v4.17 cycle (and I'm not sure how much time I can dedicate to this for the v4.18 cycle). it would be great if you could keep me CC'ed on your patches so I can learn and test them on the boards I have Regards Martin [0] https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/tools/rtlfw.c?id=8b21a74f2e473b88cadc8ad871c635ace969ee02 [1] https://github.com/torvalds/linux/commit/3a19cfcce105e481b02b14265c5b40c6c10ef60a [2] https://www.spinics.net/lists/linux-bluetooth/msg73602.html [3] https://www.spinics.net/lists/linux-bluetooth/msg73602.html
