Hi Sebastian, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on wireless-drivers-next/master] [also build test WARNING on v4.16-rc1 next-20180216] [cannot apply to ath6kl/ath-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/s-gottschall-dd-wrt-com/ath10k-add-LED-and-GPIO-controlling-support-for-various-chipsets/20180218-141132 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: openrisc-allyesconfig (attached as .config) compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental) reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=openrisc All warnings (new ones prefixed by >>): drivers/net/wireless/ath/ath10k/core.c: In function 'ath10k_register_gpio_chip': >> drivers/net/wireless/ath/ath10k/core.c:2203:5: warning: "LINUX_VERSION_CODE" is not defined [-Wundef] #if LINUX_VERSION_CODE >= KERNEL_VERSION(4,5,0) ^~~~~~~~~~~~~~~~~~ >> drivers/net/wireless/ath/ath10k/core.c:2203:27: warning: "KERNEL_VERSION" is not defined [-Wundef] #if LINUX_VERSION_CODE >= KERNEL_VERSION(4,5,0) ^~~~~~~~~~~~~~ drivers/net/wireless/ath/ath10k/core.c:2203:41: error: missing binary operator before token "(" #if LINUX_VERSION_CODE >= KERNEL_VERSION(4,5,0) ^ drivers/net/wireless/ath/ath10k/core.c:2206:13: error: 'struct gpio_chip' has no member named 'dev' gpio->gchip.dev = ar->dev; ^ vim +/LINUX_VERSION_CODE +2203 drivers/net/wireless/ath/ath10k/core.c 2191 2192 /* register GPIO chip */ 2193 static int ath10k_register_gpio_chip(struct ath10k *ar) 2194 { 2195 struct ath10k_gpiocontrol *gpio; 2196 gpio = kzalloc(sizeof(struct ath10k_gpiocontrol), GFP_KERNEL); 2197 if (!gpio) { 2198 return -1; 2199 } 2200 2201 snprintf(gpio->label, sizeof(gpio->label), "ath10k-%s", 2202 wiphy_name(ar->hw->wiphy)); > 2203 #if LINUX_VERSION_CODE >= KERNEL_VERSION(4,5,0) 2204 gpio->gchip.parent = ar->dev; 2205 #else 2206 gpio->gchip.dev = ar->dev; 2207 #endif 2208 gpio->gchip.base = -1; /* determine base automatically */ 2209 gpio->gchip.ngpio = 32; 2210 gpio->gchip.label = gpio->label; 2211 gpio->gchip.direction_input = ath10k_gpio_pin_cfg_input; 2212 gpio->gchip.direction_output = ath10k_gpio_pin_cfg_output; 2213 gpio->gchip.get_direction = ath10k_gpio_pin_get_dir; 2214 gpio->gchip.get = ath10k_gpio_pin_get; 2215 gpio->gchip.set = ath10k_gpio_pin_set; 2216 2217 if (gpiochip_add(&gpio->gchip)) { 2218 printk(KERN_ERR "Error while registering gpio chip\n"); 2219 return -1; 2220 } 2221 gpio->gchip.owner = NULL; 2222 ar->gpio = gpio; 2223 gpio->ar = ar; 2224 return 0; 2225 } 2226 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip