Hi Johannes,
On 01/31/2018 04:00 PM, Johannes Berg wrote:
Looks pretty good! Some comments over in separate emails.
Maybe you should consider reordering:
[1/6] keep
[2/6] keep
[3/6] introduce TX (now patch 5)
[4/6] introduce RX (now patch 3)
modify this to require TX from the driver in order to be able to
set the new flag
[5/6] add TX to mac80211
[6/6] add RX to mac80211 and set the flag
Ok, you don't really have to do that, since you only set the flag in
the last patch anyway, but that'd make it better to add the check that
requires TX, so you don't have to do that in the TX patch and modify
the RX portion again.
Err, Johannes Berg presents: Fun with Flags ;) So I re-read this about
half a dozen times and I think I figured out what you wanted. It seems
you mean different flags in 4/6 and 6/6. I reordered V4 with my
interpretation. Doesn't quite look like the above, but hopefully I
groked what you wanted correctly.
I didn't put in the extra owner check on the tx operation since it
wasn't clear whether you wanted that or not.
Thanks for the review.
Regards,
-Denis
