Search Linux Wireless

Re: [PATCH 5/6] nl80211: Implement TX of control port frames

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2018-01-31 at 15:33 -0600, Denis Kenzior wrote:
> 
> +	return rdev_tx_control_port(rdev, dev, buf, len,
> +				    dest, cpu_to_be16(proto), noencrypt);

You're passing __be16 here

> +++ b/net/wireless/rdev-ops.h
> @@ -714,6 +714,21 @@ static inline int rdev_mgmt_tx(struct cfg80211_registered_device *rdev,
>  	return ret;
>  }
>  
> +static inline int rdev_tx_control_port(struct cfg80211_registered_device *rdev,
> +				       struct net_device *dev,
> +				       const void *buf, size_t len,
> +				       const u8 *dest, u16 proto,
> +				       const bool noencrypt)

but have u16 here - doesn't that make sparse unhappy?

Should also declare the API as __be16.

johannes



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux