Ramon Fried <rfried@xxxxxxxxxxxxxx> writes: > wcn36xx_dxe_init() doesn't check for the return value > of wcn36xx_dxe_init_descs(). > This patch releases the resources in case an error ocurred. > > Change-Id: I924bd7489b60243c0a0cbaa716caf924f11d7587 > Signed-off-by: Ramon Fried <rfried@xxxxxxxxxxxxxx> This compiled now, thanks. But I did some minor changes in the commit log and in indentation on the pending branch: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=e5ff4344eab68c86e00036e937847ce89dfaeef6 > @@ -819,11 +847,19 @@ int wcn36xx_dxe_init(struct wcn36xx *wcn) > > ret = wcn36xx_dxe_request_irqs(wcn); > if (ret < 0) > - goto out_err; > + goto out_err_irq; The recommended style is to label the err_ based what the target does, not from where they are called from. It's easier to manage the labels that way. But as this is a style issue I didn't change it. -- Kalle Valo
