Search Linux Wireless

Fwd: iwlegacy: Please change led_mode default to _LED_RF_STATE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Emmanuel and I are not the maintainers of iwlegacy, so I'm adding
> the linux-wireless mailing list and Stanislaw, who is the actual
> maintainer.

The issue is the same for iwlwifi:
while most iwiwifi device cfgs have  led_mode = IWL_LED_RF_STATE
iwlwifi/cfg/1000.c and iwlwifi/cfg/5000.c   have led_mode = IWL_LED_BLINK,
which in turn causes the led to be configured to blink *by default*
(up to 20x/sec!),
which in turn is a human factor problem if the led is bright and/or in
the user's face.

The (potential) solution is also the same as for iwlegacy:
In iwlwifi/dvm/led.c : iwl_leds_init() : line 183

- if (mode == IWL_LED_DEFAULT)
-              mode = priv->cfg->led_mode;

+  if (mode != IWL_LED_BLINK) /* if user does not explicitly request
blink ... */
+             mode = IWL_LED_RF_STATE; /* then use a stable indicator
for sanity and consistency */


Sebastian's response that I should then update modprobe options is
missing the point.
The point is: defaults ought to be sane to begin with, and (ideally) consistent.
*I* know what to do. Many (most?) users will not, hence the dozens of
requests for help (since 2008!).

Regards,
Cyrus



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux