On Thu, 2018-01-18 at 18:10 +0530, Venkateswara Naralasetty wrote: > From: Bhagavathi Perumal S <bperumal@xxxxxxxxxxxxxx> > > This patch provides support for users to get ack signal > strength of last transmitted by introducing new attribute > 'NL80211_STA_INFO_ACK_SIGNAL'. No real objection to the patch itself, but you should say *why* you need this, and I'm not really sure I see much point in having the signal strength of the very last ACK frame? At least provide reasoning so other drivers can decide whether to implement it or not. > + * @NL80211_STA_INFO_ACK_SIGNAL: signal strength of the last ACK frame(u8, dBm) more like s8, really. johannes
