> -----Original Message----- > From: linux-wireless-owner@xxxxxxxxxxxxxxx [mailto:linux-wireless-owner@xxxxxxxxxxxxxxx] On Behalf > Of Larry Finger > Sent: Saturday, January 20, 2018 6:46 AM > To: Pkshih; kvalo@xxxxxxxxxxxxxx > Cc: linux-wireless@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 07/10] rtlwifi: btcoex: Fix some static warnings from Sparse > > On 01/19/2018 12:45 AM, pkshih@xxxxxxxxxxx wrote: > > From: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > > > > Add 'static' or declaration to resolve the warnings. > > > > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > > --- > > .../realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 36 +++++++--------------- > > .../realtek/rtlwifi/btcoexist/halbtcoutsrc.h | 4 +++ > > 2 files changed, 15 insertions(+), 25 deletions(-) > > > > diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c > b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c > > index 73ef5b271f3b..1404729441a2 100644 > > --- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c > > +++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c > > @@ -993,22 +994,6 @@ void halbtc_write_local_reg_1byte(void *btc_context, u32 reg_addr, u8 data) > > rtl_write_byte(rtlpriv, reg_addr, data); > > } > > > > -void halbtc_set_macreg(void *btc_context, u32 reg_addr, u32 bit_mask, u32 data) > > -{ > > - struct btc_coexist *btcoexist = (struct btc_coexist *)btc_context; > > - struct rtl_priv *rtlpriv = btcoexist->adapter; > > - > > - rtl_set_bbreg(rtlpriv->mac80211.hw, reg_addr, bit_mask, data); > > -} > > - > > -u32 halbtc_get_macreg(void *btc_context, u32 reg_addr, u32 bit_mask) > > -{ > > - struct btc_coexist *btcoexist = (struct btc_coexist *)btc_context; > > - struct rtl_priv *rtlpriv = btcoexist->adapter; > > - > > - return rtl_get_bbreg(rtlpriv->mac80211.hw, reg_addr, bit_mask); > > -} > > - > > Should we conclude that the two routines above are not used, and that fact was > exposed when they were made static? If so, please note that they were deleted in > the commit message. > I'll add to commit log in v2. PK
