Search Linux Wireless

Re: [PATCH 05/14] staging: wilc1000: rename camelCase used in Handle_DelAllSta() and its variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 18.01.2018 15:17, Ajay Singh wrote:
> fix "Avoid camelCase" issue reported by checkpatch.pl script.
> 
> Signed-off-by: Ajay Singh <ajay.kathat@xxxxxxxxxxxxx>
> ---
>  drivers/staging/wilc1000/host_interface.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index 9f6365a..1ac079a 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -2123,34 +2123,34 @@ static void Handle_AddStation(struct wilc_vif *vif,
>  	kfree(wid.val);
>  }
>  
> -static void Handle_DelAllSta(struct wilc_vif *vif,
> -			     struct del_all_sta *pstrDelAllStaParam)
> +static void handle_del_all_sta(struct wilc_vif *vif,
> +			       struct del_all_sta *param)
>  {
>  	s32 result = 0;
>  	struct wid wid;
> -	u8 *pu8CurrByte;
> +	u8 *curr_byte;
>  	u8 i;
> -	u8 au8Zero_Buff[6] = {0};
> +	u8 zero_buff[6] = {0};
>  
>  	wid.id = (u16)WID_DEL_ALL_STA;
>  	wid.type = WID_STR;
> -	wid.size = (pstrDelAllStaParam->assoc_sta * ETH_ALEN) + 1;
> +	wid.size = (param->assoc_sta * ETH_ALEN) + 1;
>  
> -	wid.val = kmalloc((pstrDelAllStaParam->assoc_sta * ETH_ALEN) + 1, GFP_KERNEL);
> +	wid.val = kmalloc((param->assoc_sta * ETH_ALEN) + 1, GFP_KERNEL);
>  	if (!wid.val)
>  		goto ERRORHANDLER;
>  
> -	pu8CurrByte = wid.val;
> +	curr_byte = wid.val;
>  
> -	*(pu8CurrByte++) = pstrDelAllStaParam->assoc_sta;
> +	*(curr_byte++) = param->assoc_sta;
>  
>  	for (i = 0; i < MAX_NUM_STA; i++) {
> -		if (memcmp(pstrDelAllStaParam->del_all_sta[i], au8Zero_Buff, ETH_ALEN))
> -			memcpy(pu8CurrByte, pstrDelAllStaParam->del_all_sta[i], ETH_ALEN);> +		if (memcmp(param->del_all_sta[i], zero_buff, ETH_ALEN))
For future, you could use is_zero_ether_addr() if you ensure
pstrDelAllStaParam->del_all_sta[i] is alligned to u16.

> +			memcpy(curr_byte, param->del_all_sta[i], ETH_ALEN);
>  		else
>  			continue;
>  
> -		pu8CurrByte += ETH_ALEN;
> +		curr_byte += ETH_ALEN;
>  	}
>  
>  	result = wilc_send_config_pkt(vif, SET_CFG, &wid, 1,
> @@ -2626,7 +2626,7 @@ static void host_if_work(struct work_struct *work)
>  		break;
>  
>  	case HOST_IF_MSG_DEL_ALL_STA:
> -		Handle_DelAllSta(msg->vif, &msg->body.del_all_sta_info);
> +		handle_del_all_sta(msg->vif, &msg->body.del_all_sta_info);
>  		break;
>  
>  	case HOST_IF_MSG_SET_TX_POWER:
> 



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux