On Thu, 2018-01-18 at 11:09 +0100, Johannes Berg wrote: > On Thu, 2018-01-18 at 09:05 +0000, Pkshih wrote: > > > > > > > > > > /* fast-xmit doesn't handle fragmentation at all */ > > > if (local->hw.wiphy->frag_threshold != (u32)-1 && > > > !ieee80211_hw_check(&local->hw, SUPPORTS_TX_FRAG)) > > > goto out; > > > > > Thank you for this point. This commit has not to set SUPPORTS_TX_FRAG, > > but only set SUPPORT_FAST_XMIT. I'll test and prepare for next > > submission. > But the point is that you *shouldn't* set SUPPORTS_TX_FRAG, and then > fast-xmit will only get used for non-fragmented setups, which > realistically is all anyone cares about anyway. > My fault. Since the goal of this commit is to enable fast-tx, I shouldn't set SUPPORTS_TX_FRAG and the op set_frag_threshold. PK
