Julian Calaby <julian.calaby@xxxxxxxxx> writes: > On Tue, Jan 16, 2018 at 12:18 AM, <merez@xxxxxxxxxxxxxx> wrote: >> On 2018-01-09 10:07, Kalle Valo wrote: >>> >>> Maya Erez <qca_merez@xxxxxxxxxxxxxxxx> wrote: >>> >>>> Add module parameter for configuring the headroom size >>>> in the skb allocation. >>>> >>>> Signed-off-by: Lazar Alexei <qca_ailizaro@xxxxxxxxxxxxxxxx> >>>> Signed-off-by: Maya Erez <qca_merez@xxxxxxxxxxxxxxxx> >>>> Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx> >>> >>> >>> Why? >> >> >> Some platforms have specific requirements on packet alignment. >> I will upload an update of the commit text in the next set of 11ad patches. > > Is this something the platform can tell you or something you can store > in an array by platform name? (and use the maximum size if we don't > know) > > Alternatively, would it waste too much RAM to just set this to the > maximum size and have done? > > I feel that allowing the user to set it will be problematic. I feel the same. I don't think this is something which should be controlled with a module parameter, instead the driver should choose it automatically. -- Kalle Valo
