Search Linux Wireless

Re: [PATCH v2] brcmfmac: fix CLM load error for legacy chips when user helper is enabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2018/1/16 上午 03:54, Arend van Spriel wrote:
On 1/15/2018 11:09 AM, Wright Feng wrote:


[...]

---
  drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 12
++++++------
  1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c
b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c
index 6a59d06..aaab0e6 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c
@@ -182,12 +182,12 @@ static int brcmf_c_process_clm_blob(struct
brcmf_if *ifp)

      err = request_firmware(&clm, clm_name, dev);
      if (err) {
-        if (err == -ENOENT) {
-            brcmf_dbg(INFO, "continue with CLM data currently present
in firmware\n");
-            return 0;
-        }
-        brcmf_err("request CLM blob file failed (%d)\n", err);
-        return err;
+        if (err == -ENOENT || err == -EAGAIN)
+            brcmf_info("continue with CLM data in FW\n");
+        else
+            brcmf_err("request clm_blob failed(%d) continue with CLM
data in FW\n",
+                  err);

Don't see much value in doing it this way. Either way we need to inform the user about the consequence of this, ie.:

brcmf_info("no clm_blob available (%d). device may have limited channels available\n", err);
+        return 0;
      }

Regards,
Arend
Thanks for the comment, I will post patch v3 with your suggestion later.
The patch will include one brcmf_info print and returning 0 regardless
of errors from request_firmware.

Regards,
Wright



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux