Search Linux Wireless

Re: [PATCHv2] iwlwifi: add support for RFKILL_STATE_HARD_BLOCKED

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 28 Jun 2008, drago01 wrote:
> On Sat, Jun 28, 2008 at 3:14 PM, Henrique de Moraes Holschuh
> <hmh@xxxxxxxxxx> wrote:
> > On Sat, 28 Jun 2008, drago01 wrote:
> >> This patch fixes the rfkill states to set RFKILL_STATE_HARD_BLOCKED when the
> >> radio is disabled by a hardware killswitch.
> >> It does not allow setting the sw state while the device is blocked by
> >> a hardware rfkill switch.
> >
> > It should.  In fact, you should do it in a way that it is possible to
> > double-block the radio (i.e. in SW while it is blocked in HW), so that if
> > the HW block goes away, the radio remains blocked.
> >
> > Read the docs and examples again, please.  There even is special code in the
> > rfkill_toggle_radio private function to allow for it, we want drivers to be
> > able to double-block.
> 
> OK, v2 attached it allows double-block.

Looks good at first glance (I just looked over the patch, I have never
looked at the iwlwifi code, though.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux