Felix Fietkau <nbd@xxxxxxxx> wrote: > From: Fengguang Wu <fengguang.wu@xxxxxxxxx> > > drivers/net/wireless/mediatek/mt76/debugfs.c:36:0-23: WARNING: fops_regval should be defined with DEFINE_DEBUGFS_ATTRIBUTE > > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE > for debugfs files. > > Semantic patch information: > Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() > imposes some significant overhead as compared to > DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). > > Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci > > Fixes: a5f6039c8f9c ("mt76: add driver code for MT76x2e") > CC: Felix Fietkau <nbd@xxxxxxxx> > Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx> 10 patches applied to wireless-drivers-next.git, thanks. 1a2b3666da58 mt76: fix debugfs_simple_attr.cocci warnings 34152a809d8c mt76: fix returnvar.cocci warnings c2d4c8723dbf mt76x2: remove some harmless WARN_ONs in tx status and rx path ed6b43708116 mt76x2: increase OFDM SIFS time 60e2434c5f5a mt76x2: add channel argument to eeprom tx power functions 984ea50324ec mt76x2: initialize channel power limits at probe time 53aa29b274ba mt76x2: convert between per-chain tx power and combined output eb46e5b7be0d mt76x2: init: disable APCLI by default e8be626d794b mt76x2: configure rx filter based on monitor mode setting a86af66f9b0c mt76x2: init: fix rx filter default value during init -- https://patchwork.kernel.org/patch/10112577/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches