Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx> writes: > 22000 devices (previously referenced as A000) can support > short transmit queues. This means that we have less DMA > descriptors (TFD) for those shorter queues. > Previous devices must still have 256 TFDs for each queue > even if those 256 TFDs point to fewer buffers. > > When I introduced support for the short queues for 22000 > I broke older devices by assuming that they can also have > less TFDs in their queues. This led to several problems: > > 1) the payload of the commands weren't unmapped properly > which caused the SWIOTLB to complain at some point. > 2) the hardware could get confused and we get hardware > crashes. > > The corresponding bugzilla entries are: > > https://bugzilla.kernel.org/show_bug.cgi?id=198201 > https://bugzilla.kernel.org/show_bug.cgi?id=198265 > > Cc: stable@xxxxxxxxxxxxxxx # 4.14+ > Fixes: 4ecab5616023 ("iwlwifi: pcie: support short Tx queues for A000 device family") > Reviewed-by: Sharon, Sara <sara.sharon@xxxxxxxxx> > Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx> > --- > Hi Kalle, > > Luca is on vacation is 4.15 will be closed soon. > I am fixing here a bug that caused much troube on our side. > There are two bugzillas on it. Users on both bugs validated > this fix. > Please apply this on wireless-drivers.git directly and I'll sync > with Luca when he'll be back. Ok, I'll queue this for 4.15. -- Kalle Valo
