Gary Bisson <gary.bisson@xxxxxxxxxxxxxxxxxxx> writes: > On Fri, Oct 06, 2017 at 01:16:13PM +0200, Gary Bisson wrote: >> On Thu, Oct 05, 2017 at 10:54:26PM +0530, Alagu Sankar wrote: >> > On 05-10-2017 20:42, Gary Bisson wrote: >> > > >> > > First of all, thank you for sharing your patches, this will be a very >> > > nice improvement to have SDIO QCA9377 working with ath10k. >> > > >> > > I've tried your series with Nitrogen7 [1] platform which is supported in >> > > mainline already. It uses BD-SDMAC [2] which uses the same module as the >> > > SX-SDMAC. >> > > >> > > Below are some questions/remarks I have after the testing. >> > > >> > > Quick question on the firmware, is it the one from Kalle's repository?[3] >> > > >> > > If so, where does this firmware comes from? Is 00061 the firmware >> > > version? So far I've only seen up to v0.0.0.60, see qcacld-2.0 output: >> > > Host SW:4.5.20.037, FW:0.0.0.60, HW:QCA9377_REV1_1 >> > >> > Yes, it is from >> > https://github.com/kvalo/ath10k-firmware/tree/master/QCA9377/hw1.0/untested. >> > I have also used custom firmware from QCA/Silex as used in qcacld-2.0 driver >> > without any issue. You need to use the firmware merger tool from >> > https://github.com/erstrom/linux-ath/wiki/Firmware to combine the >> > qwlan30.bin and otp30.bin to generate the firmware-sdio.bin. >> >> Good to know, thanks. Maybe Kalle can tell us more about the firmware >> itself, what's the difference between the version 0.0.0.60 and 0.0.0.61? > > Any update on this, is there a release notes for this 0.0.0.61 firmware? Unfortunately I don't have any changelogs for the firmware releases. > As a FYI, I've tried your ath10k patches (along with a few backported > patches from Erik) on the NXP-fork of 4.9 kernel [1]. > > I confirm that it provides pretty decent performances: > - ath10k: 110Mbit/s > - qcacld-2.0: 125Mbit/s > > Here are some details about the setup: > - TPLink AC router > - Nitrogen7 (i.MX7) with BD-SDMAC > - Kernel 4.9.68 (NXP fork [1]) > - FW 0.0.0.61 from ath10k-firmware repo Nice, thanks for the report. This is always helpful. -- Kalle Valo