On Fri, Jun 27, 2008 at 10:12 PM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
>
>> > >> Strawman patch below...
>> > >
>> > > You need to allow 0 through, since you can just set the transmit key
>> > > index via ENCODE without setting the key. So the legal values are 0, 5,
>> > > and 13. Add 'case 0: /* just setting TX index */' or something and I'll
>> > > definitely ack it.
>
>> > >> + switch (erq->length) {
>> > >> + case KEY_SIZE_WEP40:
>> > >> + case KEY_SIZE_WEP104:
>> > >> + break;
>> > >> + default:
>> > >> + return -EINVAL;
>> > >> + }
>> > >> +
>> > >> sdata = IEEE80211_DEV_TO_SUB_IF(dev);
>> > >>
>> > >> idx = erq->flags & IW_ENCODE_INDEX;
>> > >> --
>> > >> 1.5.5.1
>> >
>> > I'm not against this patch just I thought we agreed to support the
>> > weird WEP keys in the software. We fixed this in the driver with
>> > similar check so now it falls back to software encryption in mac80211.
>>
>> I thought we agreed to ignore > 104/128-bit WEP keys [1][2] until enough
>> people yelled about it (I've heard from 1 or 2 people in the past three
>> years about this for NetworkManager).
>
> I agree, who wants to write the support for that in mac80211. I said
> that we don't want to catch it in wext itself like an early patch did
> because some fullmac drivers might support it.
>
Fair enough. Actually have a similar patch in my stock. I will send it out.
Tomas
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
