On 12/11/2017 8:38 AM, Wright Feng wrote:
The buffer size of return of cap iovar is greater than 256 bytes in some firmwares. For instance, the return size of cap iovar is 271 bytes in 4373 13.10.246.79 firmare. It makes feature capability parsing failed because caps buffer is default value. So we enlarge caps buffer size to 512 bytes and add the error print for cap iovar error.
Looks fine to me. However, firmware side is also broken for some chips where released firmware uses 256 bytes (= WLC_IOCTL_SMLEN) but the capability tokens do no longer fit that size and we get a cut-off capability string.
Anyway... Acked-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>
Signed-off-by: Wright Feng <wright.feng@xxxxxxxxxxx> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
