Hi Kalle, On Thu, Dec 07, 2017 at 03:42:39PM +0200, Kalle Valo wrote:
kbuild test robot <lkp@xxxxxxxxx> writes:drivers/net/wireless/mediatek/mt76/debugfs.c:36:0-23: WARNING: fops_regval should be defined with DEFINE_DEBUGFS_ATTRIBUTE Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE for debugfs files. Semantic patch information: Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() imposes some significant overhead as compared to DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Fixes: a5f6039c8f9c ("mt76: add driver code for MT76x2e") CC: Felix Fietkau <nbd@xxxxxxxx> Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>I would like to apply this but the From field doesn't match the s-o-b line. This patch is created automatically, right? I think the best is that if you modify your script to add this to the beginning of the commit log: From: Fengguang Wu <fengguang.wu@xxxxxxxxx> That way From and s-o-b match and you can continue to submit it from the lkp address.
Good idea! I'll follow up with the change. Thanks, Fengguang
