Hello Kalle, > Sergey Matyukevich <sergey.matyukevich.os@xxxxxxxxxxxxx> writes: > > > From: Vasily Ulyanov <vulyanov@xxxxxxxxxxxxx> > > > > This allows a running AP to blacklist STAs by their MAC addresses > > respecting the configured policy (either accept or deny unless listed). > > It can be setup on .start_ap or with .set_mac_acl commands. > > > > Signed-off-by: Vasily Ulyanov <vulyanov@xxxxxxxxxxxxx> > > [...] > > > @@ -918,6 +933,7 @@ int qtnf_wiphy_register(struct qtnf_hw_info *hw_info, struct qtnf_wmac *mac) > > wiphy->max_scan_ie_len = QTNF_MAX_VSIE_LEN; > > wiphy->mgmt_stypes = qtnf_mgmt_stypes; > > wiphy->max_remain_on_channel_duration = 5000; > > + wiphy->max_acl_mac_addrs = mac->macinfo.max_acl_mac_addrs; > > > > wiphy->iface_combinations = iface_comb; > > wiphy->n_iface_combinations = 1; > > @@ -932,6 +948,9 @@ int qtnf_wiphy_register(struct qtnf_hw_info *hw_info, struct qtnf_wmac *mac) > > WIPHY_FLAG_AP_UAPSD | > > WIPHY_FLAG_HAS_CHANNEL_SWITCH; > > > > + if (wiphy->max_acl_mac_addrs > 0) > > + wiphy->flags |= WIPHY_FLAG_HAVE_AP_SME; > > Conditonally enabling WIPHY_FLAG_HAVE_AP_SME looks somewhat suspicious > to me and from a quick search I don't see any other driver doing > something similar. Can you explain why AP_SME is related to MAC ACL? Wireless core performs several sanity check on wiphy registration: see wiphy_register implementation in net/wireless/core.c. One of those checks is as follows: if max_acl_mac_addrs is non-zero, then two conditions should be fulfilled: - cfg80211 set_mac_acl callback should be available - WIPHY_FLAG_HAVE_AP_SME should be set The first condition is perfectly sane: it should be possible to set MACs to enable ACL feature. The second condition is that clear to me, but we have to comply in order to pass wiphy_registration. I assume that it somehow related to hostapd logic, but I haven't yet check that myself. The conditional enablement of WIPHY_FLAG_HAVE_AP_SME is easy to explain. We enable use firmware/hardware features to implement MAC-based ACL. So we enable it only if firmware report non-zero max_acl_mac_addrs value. Regards, Sergey
