Hi Thomas On Fri, 27 Jun 2008 00:51:57 +0300, "Tomas Winkler" <tomasw@xxxxxxxxx> wrote: > On Thu, Jun 26, 2008 at 9:23 PM, Johannes Berg > <johannes@xxxxxxxxxxxxxxxx> wrote: >> On Thu, 2008-06-26 at 13:55 -0400, John W. Linville wrote: >>> On Thu, Jun 26, 2008 at 07:40:58PM +0200, Samuel Ortiz wrote: >>> > Hi John, >>> > >>> > On Fri, Nov 16, 2007 at 07:53:26PM +0100, Miguel Botón wrote: >>> > > Ok, the previous patch had a little error. >>> > > >>> > > -- >>> > > >>> > > This patch adds power management support in mac80211. >>> > Sorry for being late to the game, but would a similar patch against > your >>> > -next-2.6 tree be considered for inclusion ? >>> >>> It seems like a reasonable start to me. Anyone else have comments? >> >> I had one about it returning -EINVAL for all errors that was never >> addressed afaict. > > Didn't Yi submitted this one like year ago and rejected? I searched through the mailing list, but couldnt find anything else than this patch. > This is why we have currently implemented in iwlwif sysfs. > > /sys/class/net/wlanX/devices/power_level > there are defined 6 power levels > 0 - CAM mode (Continuous Aware Mode) > 6 - AUTO > 1 to 5 levels that specifies power save aggressiveness empirically > developed. > AUTO - depends on system power source/level > system power level is AC or BATTERY - currently we do not have > anything that tells us whether we run on battery or ac. > Other factor is association state. > > This can be expressed as > iwconfig power saving 1..5 > iwconfig power off - > CAM mode > iwconfig power auto - this is unfortunately not defined by iwconfig > > If this acceptable we can submit the patch Are you talking about the wext patch, or the sysfs one ? I'd definitely be happy to have a look at the wext one. Cheers, Samuel. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html