On Thu, Jun 26, 2008 at 10:59 PM, Ivo van Doorn <ivdoorn@xxxxxxxxx> wrote: > On Thursday 26 June 2008, Abhijeet Kolekar wrote: >> iwlwifi : Patch adds rfkill subsystem for 3945 >> >> The patch removes the sysfs interface from iwl3945 and uses >> the rfkill subsystem instead. > > Shouldn't the driver depend on CONFIG_RFKILL? > Otherwise compilation will fail when CONFIG_RFKILL isn't selected... "[PATCH -next] iwlwifi: fix build for CONFIG_INPUT=n" adresses part of this. IWLWIFI_RFKILL depends on IWLCORE but iwl3945 does not use iwlcore module. Should we just add a IWL3945_RFKILL and add he changes from the mentioned patch to 3945 too? If its ok I can send a patch. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html