On Thursday 26 June 2008, Ivo van Doorn wrote:
> On Thursday 26 June 2008, Johannes Berg wrote:
> > This patch makes the mac80211 workqueue freezable making it
> > interact a bit better with system suspend and not try to ping
> > the AP while the hardware is down.
> >
> > This doesn't really help with implementing proper suspend in
> > any way but makes some bad things trigger less.
> >
> > Signed-off-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> > ---
> > I'm not sure whether we should put this into 2.6.26 or not, while it
> > might help a bit it doesn't really do much over what the tx bugs finder
> > already does except avoid sending out the packets that froze b43 in the
> > first place...
> >
> > Ivo, you might consider using create_freezeable_workqueue for your
> > rt2x00 patch though.
>
> Will do. Thanks for the tip.
Ehm, on second thought I keep it as it is. Currently the rt2x00 will already shut
down all work tasks during suspend and resumes them when the device is restored.
The only task that needs to survive the suspend and resume task is the link tuner,
and that one is automatically started when the radio is reenabled. And not stopping
it manually during suspend, will cause problems (aka race conditions, which have
appeared in the past when the link tuner continues running while the radio is down)
Ivo
> > net/mac80211/main.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- everything.orig/net/mac80211/main.c 2008-06-26 18:21:14.000000000 +0200
> > +++ everything/net/mac80211/main.c 2008-06-26 18:21:16.000000000 +0200
> > @@ -1774,7 +1774,7 @@ int ieee80211_register_hw(struct ieee802
> > list_add_tail(&sdata->list, &local->interfaces);
> >
> > name = wiphy_dev(local->hw.wiphy)->driver->name;
> > - local->hw.workqueue = create_singlethread_workqueue(name);
> > + local->hw.workqueue = create_freezeable_workqueue(name);
> > if (!local->hw.workqueue) {
> > result = -ENOMEM;
> > goto fail_workqueue;
> >
> >
> >
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
