On Fri, Nov 10, 2017 at 08:15:19AM +0200, Kalle Valo wrote: > Wright Feng <wright.feng@xxxxxxxxxxx> writes: > > > From: Chung-Hsien Hsu <stanley.hsu@xxxxxxxxxxx> > > > > The firmware for brcmfmac devices includes information regarding > > regulatory constraints. For certain devices this information is kept > > separately in a binary form that needs to be downloaded to the device. > > This patch adds support to download this so-called CLM blob file. It > > uses the same naming scheme as the other firmware files with extension > > of .clm_blob. > > > > The CLM blob file is optional. If the file does not exist, the download > > process will be bypassed. It will not affect the driver loading. > > > > Signed-off-by: Chung-Hsien Hsu <stanley.hsu@xxxxxxxxxxx> > > [...] > > > + err = brcmf_fil_iovar_data_get(ifp, "clmver", buf, sizeof(buf)); > > + if (err) { > > + if (err == -23) { > > No magic numbers, please. Is this supposed to be -ENFILE? It indicates "Unsupported". I will remove it since it will not affect the CLM downlaod and driver loading. Regards, Chung-Hsien > > -- > Kalle Valo