> > > > The issue that seems to point to has been fixed a while ago; I'll send > > and updated patch with a better commit message (also forgot to cc the > > ath10k list, I see). > > > > -Toke > > Hmm. I remember that thread. I thought we'd basically resolved that issue (45% > of the time spent in fq_codel_drop under udp flood), back then, with eric adding > the batch drop fix to fq_codel itself: > > See commit: https://osdn.net/projects/android- > x86/scm/git/kernel/commits/9d18562a227874289fda8ca5d117d8f503f1dcca > > which fixed up the problem beautifully: > > https://lists.bufferbloat.net/pipermail/make-wifi-fast/2016-May/000590.html > > So if we've been carrying this darn patch for the ath10k vs something that we'd > actually fixed elsewhere in the stack, for over a year, sigh. > Dave, Agree.. Even I am not fan of that patch in ath10k. IIRC Michal pushed this change as temp one and planned to revert it once it is fixed in stack or in driver. I thought Eric change in fq_codel is meant only for fatty udp flows. Forgive my ignorance. -Rajkumar
