Hi Brian, > On Mon, Oct 30, 2017 at 06:47:58PM +0000, Ganapathi Bhat wrote: > > > -------------------------------------------------------------------- > > > -- On Mon, Oct 30, 2017 at 02:13:31PM +0000, Ganapathi Bhat wrote: > > > > > --- a/WHENCE > > > > +++ b/WHENCE > > > > @@ -757,7 +757,7 @@ File: mrvl/pcieuart8997_combo_v4.bin > > > > Version: 16.68.1.p70 > > > > > > > > File: mrvl/pcieusb8997_combo_v4.bin > > > > -Version: 16.68.1.p133 > > > > +Version: 16.68.1.p40 > > > > > > This says .p40, whereas the commit message (and the version tag > > > within the > > > firmware) says p140. I think you're missing a "1". > > I did miss this. Will it make sense to trigger another pull request with just > the version change? > > Sure, why not? Email is cheap, and so is git. Either rewrite the commit or add > another on top to fix it... Ok, prepared the follow up patch. Let me also know if we can send a merge request while previous one is pending? If that is not the case I will send it as soon as the current request is merged. Thanks, Ganapathi
