Search Linux Wireless

Re: [PATCH 4/5] wlcore: Use common error handling code in wlcore_set_beacon_template()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Julian Calaby <julian.calaby@xxxxxxxxx>, linux-wireless <linux-wireless@xxxxxxxxxxxxxxx>, netdev <netdev@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH 4/5] wlcore: Use common error handling code in wlcore_set_beacon_template()
From: SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Mon, 30 Oct 2017 14:44:31 +0100
Cc: Arend Van Spriel <arend.vanspriel@xxxxxxxxxxxx>, Eyal Reizer <eyalr@xxxxxx>, Iain Hunter <drhunter95@xxxxxxxxx>, James Minor <james.minor@xxxxxx>, Johannes Berg <johannes.berg@xxxxxxxxx>, Kalle Valo <kvalo@xxxxxxxxxxxxxx>, Maxim Altshul <maxim.altshul@xxxxxx>, Pieter-Paul Giesberts <pieter-paul.giesberts@xxxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, kernel-janitors <kernel-janitors@xxxxxxxxxxxxxxx>
In-reply-to: <CAGRGNgUEFpva3ct-idAzip97eVgoDDTeEArAPcjvf90VSORA2g@mail.gmail.com>
References: <dc2b8a7c-b4a9-2f92-12b4-a1d0d6911d7c@users.sourceforge.net> <f50c8edf-834d-9003-5a3c-dc83ec4016ce@users.sourceforge.net> <CAGRGNgUEFpva3ct-idAzip97eVgoDDTeEArAPcjvf90VSORA2g@mail.gmail.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

>> @@ -4081,9 +4078,8 @@ static int wlcore_set_beacon_template(struct wl1271 *wl,
>>                                               beacon->data,
>>                                               beacon->len, 0,
>>                                               min_rate);
>> -end_bcn:
>> +free_skb:
> 
> Why rename the label?

I find it clearer according to the Linux coding style.

Regards,
Markus

References:
- [PATCH 0/5] wlcore: Fine-tuning for three function implementations
  - From: SF Markus Elfring
- [PATCH 4/5] wlcore: Use common error handling code in wlcore_set_beacon_template()
  - From: SF Markus Elfring
- Re: [PATCH 4/5] wlcore: Use common error handling code in wlcore_set_beacon_template()
  - From: Julian Calaby

Prev by Date: Re: [PATCH 5/5] wlcore: Use common error handling code in wl1271_op_suspend()
Next by Date: pull-request mwifiex-firmware 2017-10-30
Previous by thread: Re: [PATCH 4/5] wlcore: Use common error handling code in wlcore_set_beacon_template()
Next by thread: [PATCH 5/5] wlcore: Use common error handling code in wl1271_op_suspend()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Host AP] [ATH6KL] [Linux Wireless Personal Area Network] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Linux Kernel] [IDE] [Git] [Netfilter] [Bugtraq] [Yosemite Hiking] [MIPS Linux] [ARM Linux] [Linux RAID]