Pavel Roskin wrote:
On Wed, 2008-06-25 at 12:44 -0500, Larry Finger wrote:
I'm not sure I can stand behind that patch quality-wise. It's 40k of intrusive changes that I could not even test on an old rtl8187. If I had more time and a original rtl8187 device, I would try to split more parts or restructure the code first. Also, the startup time (ifconfig up) is over 20 seconds, which is absolutely unacceptable. Either some delays are over-conservative, or we are doing something wrong.
For the review process, I have split the patch into 5 parts. Each step compiles, thus bisection will be preserved. With this change, the largest of the pieces is a little under 15KiB. Is this small enough? Further splitting would be a lot more difficult.
As to the quality of the patch, it barely works on my device. RX seems to be OK except for the wireless statistics, but I can associate only about 1 try in 10. Once I get that problem squared away, then I can work on the timing. I really would like to get this into wireless-testing ASAP.
I don't have an 8187 device either, and will have to rely on someone else for that part of the testing.
Larry -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
