Maya Erez <qca_merez@xxxxxxxxxxxxxxxx> writes:
> From: Lazar Alexei <qca_ailizaro@xxxxxxxxxxxxxxxx>
>
> Currently the statistics show how many successful/failed
> suspend/resume operations the system had.
> Update the statistics by splitting each successful/failed
> suspend/resume operations to radio on/off.
>
> Signed-off-by: Lazar Alexei <qca_ailizaro@xxxxxxxxxxxxxxxx>
> Signed-off-by: Maya Erez <qca_merez@xxxxxxxxxxxxxxxx>
> ---
> drivers/net/wireless/ath/wil6210/debugfs.c | 27 ++++++++++++++++++---------
> drivers/net/wireless/ath/wil6210/pcie_bus.c | 20 ++++++++++++++------
> drivers/net/wireless/ath/wil6210/pm.c | 8 +++++---
> drivers/net/wireless/ath/wil6210/wil6210.h | 11 ++++++++---
> 4 files changed, 45 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/wil6210/debugfs.c b/drivers/net/wireless/ath/wil6210/debugfs.c
> index 03d17ea..9164855 100644
> --- a/drivers/net/wireless/ath/wil6210/debugfs.c
> +++ b/drivers/net/wireless/ath/wil6210/debugfs.c
> @@ -1685,20 +1685,29 @@ static ssize_t wil_read_suspend_stats(struct file *file,
> size_t count, loff_t *ppos)
> {
> struct wil6210_priv *wil = file->private_data;
> - static char text[400];
> + static char text[500];
I was first about to mention about excessive stack usage but only then I
noticed the static keyword. That again is problematic when you have two
(or more) devices as then they would be accessing the same buffer,
right?
As this from debugfs interface I admit that it's a very theoretical
issue but still something which should be fixed. I can still take this
patch, but please fix the static usage in a followup patch.
--
Kalle Valo
