Search Linux Wireless

Re: [PATCH] ath5k: convert LED code to use mac80211 triggers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I do have a micro-update to this after reading over it one last time.
I'll post a respin tonight.

>>        tristate "Atheros 5xxx wireless cards support"
>>        depends on PCI && MAC80211 && WLAN_80211 && EXPERIMENTAL
>> +       select MAC80211_LEDS
>> +       select LEDS_CLASS

+ select NEW_LEDS

Randy Dunlap posted a patch series a few weeks ago that said NEW_LEDS
was required where LEDS_CLASS was used.

>> -ath5k_led_off(unsigned long data)
>> +ath5k_led_enable(struct ath5k_softc *sc)
[..]
>> +       if (test_bit(ATH_STAT_LEDSOFT, sc->status)) {
>> +               ath5k_hw_set_gpio_output(sc->ah, sc->led_pin);
>> +               ath5k_hw_set_gpio(sc->ah, sc->led_pin, 0);

That was carried over from the original code but I think it was supposed to be:

>> +               ath5k_hw_set_gpio(sc->ah, sc->led_pin, !sc->led_on);

(This changes it from 'on' to 'off' but either way I'm not sure it matters.)

> I don't have an IBM card either, anyway we need the cleanup more than
> blinking leds :-)
>
>
> Acked-by: Nick Kossifidis <mickflemm@xxxxxxxxx>

Thanks!

-- 
Bob Copeland %% www.bobcopeland.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux