On Wed, 2017-10-18 at 13:31 +0200, Johannes Berg wrote: > On Wed, 2017-10-18 at 12:29 +0200, Johannes Berg wrote: > > > Anyway, the change here looks correct to me, so I'll apply it and then > > perhaps clean up more. I've only changed "u16 tid" to "u8 tid" since > > the valid range is 0-15 (in theory, in practice 0-7). > > Well, I guess I'm clearly wrong - it's crashing our test suite left and > right. > > I'll dig a little bit, but I don't have much time today, and will be > out for a few days starting tomorrow. Ok, it's pretty obvious - you never initialize the new fields in tid_tx (sta and tid), only in tid_rx. Let's see if it passes with that fixed. johannes