Hi, > This is not dead code, we reach it in several scenarios, mainly WPS > tests. Interesting. > hostapd uses change_beacon to change the security of the AP so this > needs to be supported. I didn't think this made sense - Jouni? Does hostapd kick off all stations in this case? > We do need to restart the AP in this case which will > disconnect existing clients, but this cannot be helped... Why not restart the AP entirely then from userspace? Hmm. I wonder what would happen with mac80211 - I guess keys would have to removed etc? Does this just work by accident because mac80211 removes the keys with stations? What about GTK(s) though? > As a side note, hostapd can also use change_beacon to change the > SSID. When does that happen? > It does so by updating the SSID IE in the probe response frame. We > have a pending patch that detects this and updates the FW but we also > need to update wdev->ssid otherwise the wireless_dev will be out of > date (not sure if it will cause any problems...) Logic-wise it won't, but we do expose this to userspace and that'd be confusing, so we have to update it I guess. johannes
